Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: src/untrusted/irt/irt_interfaces.c

Issue 10826171: Incorporate shimming into the irt (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/untrusted/irt/irt_interfaces.c
===================================================================
--- src/untrusted/irt/irt_interfaces.c (revision 9574)
+++ src/untrusted/irt/irt_interfaces.c (working copy)
@@ -8,6 +8,7 @@
#include "native_client/src/include/nacl_macros.h"
#include "native_client/src/untrusted/irt/irt.h"
+#include "native_client/src/untrusted/irt/irt_shim.h"
#include "native_client/src/untrusted/irt/irt_interfaces.h"
struct nacl_interface_table {
@@ -30,9 +31,16 @@
{ NACL_IRT_BLOCKHOOK_v0_1, &nacl_irt_blockhook, sizeof(nacl_irt_blockhook) },
{ NACL_IRT_RESOURCE_OPEN_v0_1, &nacl_irt_resource_open,
sizeof(nacl_irt_resource_open) },
+/* @IGNORE_LINES_FOR_CODE_HYGIENE[1] */
Mark Seaborn 2012/08/28 20:41:00 Please indent by 2 spaces to match the surrounding
Mark Seaborn 2012/08/28 21:32:00 Ping? Please do this for the comment below too.
#ifdef IRT_PPAPI
{ NACL_IRT_PPAPIHOOK_v0_1, &nacl_irt_ppapihook, sizeof(nacl_irt_ppapihook) },
+/* This ifdef should be removed once the IRT build has migrated to the Chrome tree. */
Mark Seaborn 2012/08/28 20:41:00 Please add a TODO(robertm) in this comment. Also,
+/* @IGNORE_LINES_FOR_CODE_HYGIENE[1] */
+#ifdef ENABLE_NACL_IRT_PPAPIHOOK_SHIMMED
+ { NACL_IRT_PPAPIHOOK_SHIMMED_v0_1, &nacl_irt_ppapihook_shimmed,
+ sizeof(nacl_irt_ppapihook) },
#endif
+#endif
{ NACL_IRT_RANDOM_v0_1, &nacl_irt_random, sizeof(nacl_irt_random) },
{ NACL_IRT_CLOCK_v0_1, &nacl_irt_clock, sizeof(nacl_irt_clock) },
{ NACL_IRT_DEV_EXCEPTION_HANDLING_v0_1, &nacl_irt_dev_exception_handling,

Powered by Google App Engine
This is Rietveld 408576698