Incorporate shimming into the irt

src/untrusted/irt/irt.h

Index: src/untrusted/irt/irt.h
===================================================================
--- src/untrusted/irt/irt.h	(revision 9574)
+++ src/untrusted/irt/irt.h	(working copy)
@@ -146,7 +146,9 @@
   int (*register_block_hooks)(void (*pre)(void), void (*post)(void));
 };
 
+/* these should be kept in sync, both are using the nacl_irt_ppapihook API */

[Mark Seaborn, 2012/08/28 15:51:20]

If you are going to add comments, please make sure they are well-formatted:
sentences should start with capital letters.  The same applies to other comments
in this change.

[Robert Muth (chromium), 2012/08/28 18:13:30]

Done.

 #define NACL_IRT_PPAPIHOOK_v0_1 "nacl-irt-ppapihook-0.1"
+#define NACL_IRT_PPAPIHOOK_SHIMMED_v0_1 "nacl-irt-ppapihook-shimmed-0.1"

[Mark Seaborn, 2012/08/28 15:51:20]

So far irt.h only contains public interfaces.  I think we should probably keep
it that way, so can you find or create a different header to put this in?

[Robert Muth (chromium), 2012/08/28 18:13:30]

This is a public interface, if somebody chooses to use
the pnacl toolchain for creating nexes this is what is being used.


On 2012/08/28 15:51:20, Mark Seaborn wrote:

[Mark Seaborn, 2012/08/28 18:57:06]

That's not my and Roland's understanding.  We are not committing to supporting
more than one x86-64 calling convention ABI for NaCl.  If someone wants to use
the PNaCl toolchain to build an ABI-stable x86-64 nexe, they will have to link
the shims into the nexe (the original approach), so that the nexe uses the
original x86-64 ABI when interacting with the outside world.

[Robert Muth (chromium), 2012/08/28 20:22:46]

Done.

 struct nacl_irt_ppapihook {
   int (*ppapi_start)(const struct PP_StartFunctions *);
   void (*ppapi_register_thread_creator)(const struct PP_ThreadFunctions *);