Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: src/untrusted/irt/irt.gyp

Issue 10826171: Incorporate shimming into the irt (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/untrusted/irt/irt.gyp
===================================================================
--- src/untrusted/irt/irt.gyp (revision 9574)
+++ src/untrusted/irt/irt.gyp (working copy)
@@ -1,4 +1,4 @@
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Copyright 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -52,6 +52,21 @@
},
'targets': [
{
+ 'target_name': 'irt_core_common',
jvoung (off chromium) 2012/08/27 21:53:58 "irt_core_nexe" doesn't use a shim. How does "irt
Nick Bray (chromium) 2012/08/27 23:00:02 Instead of having the core irt depend on this. The
+ 'type': 'none',
+ 'direct_dependent_settings': {
+ 'sources': [ '<@(irt_sources)', ],
+ },
+ 'conditions': [
+ ['target_arch=="x64"', {
+ 'dependencies': [ 'shim_generator.gyp:shim_generated_source', ],
+ 'sources': [ '<(SHARED_INTERMEDIATE_DIR)/pnacl_shim.c', ],
+ }, { # else
+ 'sources': [ 'shim_dummy.c', ],
+ }],
+ ],
+ },
+ {
'target_name': 'irt_core_nexe',
'type': 'none',
'variables': {
@@ -59,7 +74,7 @@
'build_glibc': 0,
'build_newlib': 1,
},
- 'sources': ['<@(irt_sources)', '<@(irt_nonbrowser)'],
+ 'sources': ['<@(irt_nonbrowser)'],
'link_flags': [
'-lsrpc',
'-limc_syscalls',
@@ -78,8 +93,7 @@
'-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)',
]
}, { # target_arch == "arm"
- 'sources': ['<@(irt_sources)',
- 'aeabi_read_tp.S'],
+ 'sources': ['aeabi_read_tp.S'],
'cflags': ['--pnacl-allow-translate',
'-arch', 'arm'],
'asflags': ['-arch', 'arm'],
@@ -96,6 +110,7 @@
],
],
'dependencies': [
+ 'irt_core_common',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/srpc/srpc.gyp:srpc_lib',
@@ -112,7 +127,7 @@
'build_glibc': 0,
'build_newlib': 1,
},
- 'sources': ['<@(irt_sources)', '<@(irt_browser)'],
+ 'sources': ['<@(irt_browser)'],
'conditions': [
['target_arch == "x64" or target_arch == "ia32"', {
'link_flags': [
@@ -122,6 +137,7 @@
}],
],
'dependencies': [
+ 'irt_core_common',
'<(DEPTH)/native_client/tools.gyp:prep_toolchain',
'<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib_newlib',
],

Powered by Google App Engine
This is Rietveld 408576698