Adding pyautotest: testMultipleWindowCrosh

Adding pyautotest: testMultipleWindowCrosh


BUG=128108
Test=This is a test.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150203

[Nirnimesh, 2012-08-06 21:49:48]

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
File chrome/test/functional/chromeos_crosh.py (right):

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:71: self.WaitForHtermText(text='crosh>
', tab_index=1, windex=windex,
why is the tab_index hardcoded to 1?

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:74: self.GetHtermRowsText(start=0,
end=2, tab_index=1,
ditto

[tturchetto, 2012-08-06 21:53:48]

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
File chrome/test/functional/chromeos_crosh.py (right):

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:71: self.WaitForHtermText(text='crosh>
', tab_index=1, windex=windex,
On 2012/08/06 21:49:48, Nirnimesh wrote:
> why is the tab_index hardcoded to 1?

Because open browser takes tab 0, open crosh takes tab 1.

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:74: self.GetHtermRowsText(start=0,
end=2, tab_index=1,
On 2012/08/06 21:49:48, Nirnimesh wrote:
> ditto

ditto

[Nirnimesh, 2012-08-06 22:03:02]

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
File chrome/test/functional/chromeos_crosh.py (right):

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:71: self.WaitForHtermText(text='crosh>
', tab_index=1, windex=windex,
On 2012/08/06 21:53:48, tturchetto wrote:
> On 2012/08/06 21:49:48, Nirnimesh wrote:
> > why is the tab_index hardcoded to 1?
> 
> Because open browser takes tab 0, open crosh takes tab 1.

What's the point of checking the same thing 3 times in the same tab?

[tturchetto, 2012-08-06 22:28:53]

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
File chrome/test/functional/chromeos_crosh.py (right):

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:71: self.WaitForHtermText(text='crosh>
', tab_index=1, windex=windex,
On 2012/08/06 22:03:02, Nirnimesh wrote:
> On 2012/08/06 21:53:48, tturchetto wrote:
> > On 2012/08/06 21:49:48, Nirnimesh wrote:
> > > why is the tab_index hardcoded to 1?
> > 
> > Because open browser takes tab 0, open crosh takes tab 1.
> 
> What's the point of checking the same thing 3 times in the same tab?

Because if it doesn't mention the tab, test would failed because it is working
on the previous existing window.

[Nirnimesh, 2012-08-06 22:34:46]

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
File chrome/test/functional/chromeos_crosh.py (right):

https://chromiumcodereview.appspot.com/10826170/diff/1/chrome/test/functional...
chrome/test/functional/chromeos_crosh.py:71: self.WaitForHtermText(text='crosh>
', tab_index=1, windex=windex,
On 2012/08/06 22:28:53, tturchetto wrote:
> On 2012/08/06 22:03:02, Nirnimesh wrote:
> > On 2012/08/06 21:53:48, tturchetto wrote:
> > > On 2012/08/06 21:49:48, Nirnimesh wrote:
> > > > why is the tab_index hardcoded to 1?
> > > 
> > > Because open browser takes tab 0, open crosh takes tab 1.
> > 
> > What's the point of checking the same thing 3 times in the same tab?
> 
> Because if it doesn't mention the tab, test would failed because it is working
> on the previous existing window.

You're telling me symptoms for what's not working. Not specifying tab_index is
obviously wrong. I wasn't suggesting that.

I was suggesting that it should specify the right tab_index here, the one
corresponding to the crosh tab you just opened

[Nirnimesh, 2012-08-06 23:33:29]

lgtm

[commit-bot: I haz the power, 2012-08-06 23:35:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tturchetto@chromium.org/10826170/1

[commit-bot: I haz the power, 2012-08-07 01:08:01]

Change committed as 150203