Add build/ios/mac_build.gypi for building Mac components used by iOS build

Add build/ios/mac_build.gypi for building Mac components used by iOS build

The mac_build.gypi is used to build Mac targets via ninja. The template runs gyp_chromium to generate a ninja project file, then gyp target that includes the template should include an action to run ninja for the desired targets.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150357

[qsr, 2012-08-07 08:23:43]

LGTM with nit.

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gypi
File build/ios/mac_build.gypi (right):

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:81: # Local Variables:
Kill those.

[stuartmorgan, 2012-08-07 08:42:36]

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gypi
File build/ios/mac_build.gypi (right):

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:5: # Xcode throws an error if an iOS target depends on
Mac OS X target.  So
s/on/on a/
(you'll have to re-wrap the comment)

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:46: '<(DEPTH)/build/ios/clean_env.py',
Might I recommend adding clean_env.py to this CL :)

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:47: # ninja must be found in the PATH
Add a .

[lliabraa, 2012-08-07 14:17:05]

Thanks for the reviews.

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gypi
File build/ios/mac_build.gypi (right):

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:5: # Xcode throws an error if an iOS target depends on
Mac OS X target.  So
On 2012/08/07 08:42:36, stuartmorgan wrote:
> s/on/on a/
> (you'll have to re-wrap the comment)

Done.

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:47: # ninja must be found in the PATH
On 2012/08/07 08:42:36, stuartmorgan wrote:
> Add a .

Done.

https://chromiumcodereview.appspot.com/10826169/diff/1/build/ios/mac_build.gy...
build/ios/mac_build.gypi:81: # Local Variables:
On 2012/08/07 08:23:43, qsr wrote:
> Kill those.

Done.

[stuartmorgan, 2012-08-07 14:26:26]

LGTM with nits

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py
File build/ios/clean_env.py (right):

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:11: through to the command being run.  It attempts to
strip off Xcode added
Xcode-added

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:29: assert(len(argv) > 0)
It would be nice if this did a usage+exit instead of asserting, but it's not
something we need for this CL. Maybe TODO it?

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:55: filtered_chunks = \
Is the continuation actually necessary here? I would think this would be
implicit.

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:73: return 66
Do you know if 66 is a meaningful value, or is it just something we don't think
will collide? Could use a comment.

[lliabraa, 2012-08-07 14:48:18]

Thanks again

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py
File build/ios/clean_env.py (right):

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:11: through to the command being run.  It attempts to
strip off Xcode added
On 2012/08/07 14:26:26, stuartmorgan wrote:
> Xcode-added

Done.

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:29: assert(len(argv) > 0)
On 2012/08/07 14:26:26, stuartmorgan wrote:
> It would be nice if this did a usage+exit instead of asserting, but it's not
> something we need for this CL. Maybe TODO it?

Done.

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:55: filtered_chunks = \
On 2012/08/07 14:26:26, stuartmorgan wrote:
> Is the continuation actually necessary here? I would think this would be
> implicit.

Nope - omitting the \ will give a syntax error. If the open bracket was on the
same line as 'filtered_chunks = ' then the continuation would be implicit, but I
think the preferred style for generators is to put them all on one line.

https://chromiumcodereview.appspot.com/10826169/diff/4/build/ios/clean_env.py...
build/ios/clean_env.py:73: return 66
On 2012/08/07 14:26:26, stuartmorgan wrote:
> Do you know if 66 is a meaningful value, or is it just something we don't
think
> will collide? Could use a comment.

It is not meaningful to me and I didn't see anything obvious on the interwebs.

Added a comment.

[commit-bot: I haz the power, 2012-08-07 14:48:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10826169/9001

[commit-bot: I haz the power, 2012-08-07 16:06:35]

Change committed as 150357