Issue 10826160: Restore NativeWidgetWin::OnSetIcon to eliminate classic theme titlebar flickering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826160: Restore NativeWidgetWin::OnSetIcon to eliminate classic theme titlebar flickering. (Closed)

Created:
8 years, 4 months ago by msw

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restore NativeWidgetWin::OnSetIcon to eliminate classic theme titlebar flickering. OnSetIcon (and OnSetText) were removed in crrev.com/111858. That was a speculative fix for crbug.com/97808. DefWindowProc for WM_SETICON does weird non-client painting. We need a ScopedRedrawLock to avoid flickering on title/icon updates. TEST=No Windows classic theme titlebar flickering. BUG=97808, 140674 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150104

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	ui/views/widget/native_widget_win.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	ui/views/widget/native_widget_win.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

msw

Hey Ben and Scott, please take a look; thanks! I still haven't tracked down the ...

8 years, 4 months ago (2012-08-05 02:58:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10826160/1

8 years, 4 months ago (2012-08-06 15:43:20 UTC) #3

Change committed as 150104

Expand Messages | Collapse Messages