Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: webkit/support/platform_support_android.cc

Issue 10826158: Change of DumpRenderTree directory on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/platform_support_android.cc
diff --git a/webkit/support/platform_support_android.cc b/webkit/support/platform_support_android.cc
index cce355752c8b71b769bba7a8a4c43f22201de47c..4183312175e581cdf5fabcafd0759be8fdf6ece1 100644
--- a/webkit/support/platform_support_android.cc
+++ b/webkit/support/platform_support_android.cc
@@ -24,9 +24,7 @@ namespace {
// The place where the Android layout test script will put the required tools
// and resources. Must keep consistent with DEVICE_DRT_DIR in
// WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py.
-// TODO(wangxianzhu): Allow running DRT on non-rooted device by putting
-// the tools and resources into the apk or under /data/local/tmp.
-const char kDumpRenderTreeDir[] = "/data/drt";
+const char kDumpRenderTreeDir[] = "/data/local/tmp/drt";
}
@@ -35,6 +33,11 @@ namespace webkit_support {
void BeforeInitialize(bool unit_test_mode) {
base::InitAndroidTestPaths();
+ // Place cache under kDumpRenderTreeDir to allow the NRWT script to clear it.
+ FilePath path(kDumpRenderTreeDir);
+ path = path.Append("cache");
+ PathService::Override(base::DIR_CACHE, path);
+
// Set XML_CATALOG_FILES environment variable to blank to prevent libxml from
// loading and complaining the non-exsistent /etc/xml/catalog file.
setenv("XML_CATALOG_FILES", "", 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698