Check for warnings when loading extensions in browser tests.

chrome/browser/extensions/extension_resource_request_policy_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/mock_host_resolver.h"
 
 class ExtensionResourceRequestPolicyTest : public ExtensionApiTest {
  protected:
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     ExtensionApiTest::SetUpCommandLine(command_line);
     command_line->AppendSwitch(switches::kAllowLegacyExtensionManifests);
   }
 };
 
 // Note, this mostly tests the logic of chrome/renderer/extensions/
 // extension_resource_request_policy.*, but we have it as a browser test so that
 // can make sure it works end-to-end.
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, OriginPrivileges) {
   host_resolver()->AddRule("*", "127.0.0.1");
   ASSERT_TRUE(test_server()->Start());
-  ASSERT_TRUE(LoadExtension(test_data_dir_
+  ASSERT_TRUE(LoadExtensionWithFlags(test_data_dir_
       .AppendASCII("extension_resource_request_policy")
-      .AppendASCII("extension")));
+      .AppendASCII("extension"),
+      // Tests manifest_version 1 behavior, so warnings are expected.
+      ExtensionBrowserTest::kFlagIgnoreManifestWarnings));
 
   GURL web_resource(
       test_server()->GetURL(
           "files/extensions/api_test/extension_resource_request_policy/"
           "index.html"));
 
   std::string host_a("a.com");
   GURL::Replacements make_host_a_com;
   make_host_a_com.SetHostStr(host_a);
 
@@ skipping 32 matching lines @@
   ui_test_utils::NavigateToURL(browser(),
       GURL(std::string("data:text/html;charset=utf-8,") + file_source));
   ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
       chrome::GetActiveWebContents(browser())->GetRenderViewHost(), L"",
       L"window.domAutomationController.send(document.title)",
       &result));
   EXPECT_EQ(result, "Loaded");
 
   // A different extension. Legacy (manifest_version 1) extensions should always
   // be able to load each other's resources.
-  ASSERT_TRUE(LoadExtension(test_data_dir_
+  ASSERT_TRUE(LoadExtensionWithFlags(test_data_dir_
       .AppendASCII("extension_resource_request_policy")
-      .AppendASCII("extension2")));
+      .AppendASCII("extension2"),
+      // Tests manifest_version 1 behavior, so warnings are expected.
+      ExtensionBrowserTest::kFlagIgnoreManifestWarnings));
   ui_test_utils::NavigateToURL(
       browser(),
       GURL("chrome-extension://pbkkcbgdkliohhfaeefcijaghglkahja/index.html"));
   ASSERT_TRUE(content::ExecuteJavaScriptAndExtractString(
       chrome::GetActiveWebContents(browser())->GetRenderViewHost(), L"",
       L"window.domAutomationController.send(document.title)",
       &result));
   EXPECT_EQ(result, "Loaded");
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,
                        ExtensionCanLoadHostedAppIcons) {
-  ASSERT_TRUE(LoadExtension(test_data_dir_
+  ASSERT_TRUE(LoadExtensionWithFlags(test_data_dir_
       .AppendASCII("extension_resource_request_policy")
-      .AppendASCII("extension")));
+      .AppendASCII("extension"),
+      // Tests manifest_version 1 behavior, so warnings are expected.
+      ExtensionBrowserTest::kFlagIgnoreManifestWarnings));
 
   ASSERT_TRUE(RunExtensionSubtest(
       "extension_resource_request_policy/extension2/",
-      "can_load_icons_from_hosted_apps.html"));
+      "can_load_icons_from_hosted_apps.html",
+      // Tests manifest_version 1 behavior, so warnings are expected.
+      ExtensionApiTest::kFlagIgnoreManifestWarnings)) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, Audio) {
   EXPECT_TRUE(RunExtensionSubtest(
       "extension_resource_request_policy/extension2",
-      "audio.html"));
+      "audio.html",
+      // Tests manifest_version 1 behavior, so warnings are expected.
+      ExtensionApiTest::kFlagIgnoreManifestWarnings)) << message_;
 }
 
 #if defined(OS_MACOSX)
 // http://crbug.com/95274 - Video is flaky on Mac.
 #define MAYBE_Video DISABLED_Video
 #else
 #define MAYBE_Video Video
 #endif
 
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, MAYBE_Video) {
   EXPECT_TRUE(RunExtensionSubtest(
       "extension_resource_request_policy/extension2",
-      "video.html"));
+      "video.html",
+      // Tests manifest_version 1 behavior, so warnings are expected.
+      ExtensionApiTest::kFlagIgnoreManifestWarnings)) << message_;
 }
 
 // This test times out regularly on win_rel trybots. See http://crbug.com/122154
 #if defined(OS_WIN)
 #define MAYBE_WebAccessibleResources DISABLED_WebAccessibleResources
 #else
 #define MAYBE_WebAccessibleResources WebAccessibleResources
 #endif
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,
                        MAYBE_WebAccessibleResources) {
@@ skipping 107 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, Iframe) {
   // Load another extension, which the test one shouldn't be able to get
   // resources from.
   ASSERT_TRUE(LoadExtension(test_data_dir_
       .AppendASCII("extension_resource_request_policy")
       .AppendASCII("inaccessible")));
   EXPECT_TRUE(RunExtensionSubtest(
       "extension_resource_request_policy/web_accessible",
-      "iframe.html"));
+      "iframe.html")) << message_;
 }
 
 #if defined(OS_MACOSX)
 #define MAYBE_ExtensionAccessibleResources FLAKY_ExtensionAccessibleResources
 #else
 #define MAYBE_ExtensionAccessibleResources ExtensionAccessibleResources
 #endif
 IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,
                        MAYBE_ExtensionAccessibleResources) {
   ASSERT_TRUE(RunExtensionSubtest("accessible_cer", "main.html")) << message_;
 }