Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: chrome/chrome_exe.gypi

Issue 10826155: Cleanup: Remove an obsolete TODO. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'chrome', 8 'target_name': 'chrome',
9 'type': 'executable', 9 'type': 'executable',
10 'mac_bundle': 1, 10 'mac_bundle': 1,
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 # NOTE: chrome/app/theme/chromium/BRANDING and 409 # NOTE: chrome/app/theme/chromium/BRANDING and
410 # chrome/app/theme/google_chrome/BRANDING have the short name 410 # chrome/app/theme/google_chrome/BRANDING have the short name
411 # "chrome" etc.; should we try to extract from there instead? 411 # "chrome" etc.; should we try to extract from there instead?
412 412
413 # On Mac, this is done in chrome_dll.gypi. 413 # On Mac, this is done in chrome_dll.gypi.
414 ['internal_pdf', { 414 ['internal_pdf', {
415 'dependencies': [ 415 'dependencies': [
416 '../pdf/pdf.gyp:pdf', 416 '../pdf/pdf.gyp:pdf',
417 ], 417 ],
418 'conditions': [ 418 'conditions': [
419 # TODO(thestig) It would be nice to do this for CrOS as well, 419 # CrOS does this in a separate build step.
420 # but when I tried that, it failed because dump_syms is built
421 # for the target arch rather than the host arch.
422 # http://crbug.com/140571
423 ['OS=="linux" and chromeos==0 and linux_dump_symbols==1', { 420 ['OS=="linux" and chromeos==0 and linux_dump_symbols==1', {
424 'dependencies': [ 421 'dependencies': [
425 '../pdf/pdf.gyp:pdf_linux_symbols', 422 '../pdf/pdf.gyp:pdf_linux_symbols',
426 ], 423 ],
427 }], # OS=="linux" and linux_dump_symbols==1 424 }], # OS=="linux" and chromeos==0 and linux_dump_symbols==1
428 ], 425 ],
429 }], # internal_pdf 426 }], # internal_pdf
430 ], 427 ],
431 'dependencies': [ 428 'dependencies': [
432 'chrome_resources.gyp:packed_extra_resources', 429 'chrome_resources.gyp:packed_extra_resources',
433 'chrome_resources.gyp:packed_resources', 430 'chrome_resources.gyp:packed_resources',
434 # Copy Flash Player files to PRODUCT_DIR if applicable. Let the .gyp 431 # Copy Flash Player files to PRODUCT_DIR if applicable. Let the .gyp
435 # file decide what to do on a per-OS basis; on Mac, internal plugins 432 # file decide what to do on a per-OS basis; on Mac, internal plugins
436 # go inside the framework, so this dependency is in chrome_dll.gypi. 433 # go inside the framework, so this dependency is in chrome_dll.gypi.
437 '../third_party/adobe/flash/flash_player.gyp:flash_player', 434 '../third_party/adobe/flash/flash_player.gyp:flash_player',
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 'target_name': 'chrome_nacl_win64', 598 'target_name': 'chrome_nacl_win64',
602 'type': 'none', 599 'type': 'none',
603 'sources': [], 600 'sources': [],
604 }, 601 },
605 ], 602 ],
606 }], 603 }],
607 ], 604 ],
608 }], 605 }],
609 ], 606 ],
610 } 607 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698