Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10826152: make egl_native.cc compile on OSX (Closed)

Created:
8 years, 4 months ago by greggman
Modified:
8 years, 4 months ago
Reviewers:
bbudge
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

make egl_native.cc compile on OSX No idea why this doesn't work sometimes. It works for me but not for others. Maybe which verison of XCode? BUG=83382 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/gles2_conform_support/native/egl_native.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
greggman
Hey Bill, PTAL
8 years, 4 months ago (2012-08-03 22:01:36 UTC) #1
bbudge
I am using the latest version (installed Wednesday from App Store) on Mountain Lion. LGTM
8 years, 4 months ago (2012-08-03 22:06:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10826152/1
8 years, 4 months ago (2012-08-03 22:14:18 UTC) #3
commit-bot: I haz the power
Try job failure for 10826152-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 22:38:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10826152/1
8 years, 4 months ago (2012-08-04 00:52:21 UTC) #5
commit-bot: I haz the power
Try job failure for 10826152-1 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 4 months ago (2012-08-04 02:38:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10826152/1
8 years, 4 months ago (2012-08-04 08:12:00 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 09:15:23 UTC) #8
Change committed as 150029

Powered by Google App Engine
This is Rietveld 408576698