Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: chrome/renderer/extensions/user_script_scheduler.cc

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: win compile fix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/extension_helper.cc ('k') | chrome/renderer/extensions/user_script_slave.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/user_script_scheduler.cc
diff --git a/chrome/renderer/extensions/user_script_scheduler.cc b/chrome/renderer/extensions/user_script_scheduler.cc
index 5ad107c028e3adae59bd5854ded218321ad0fd61..53e67178d072ebc7958ef8fce825ba6bb85597c1 100644
--- a/chrome/renderer/extensions/user_script_scheduler.cc
+++ b/chrome/renderer/extensions/user_script_scheduler.cc
@@ -145,7 +145,11 @@ void UserScriptScheduler::ExecuteCodeImpl(
// be out of sync. We just ignore this situation.
if (!extension) {
render_view->Send(new ExtensionHostMsg_ExecuteCodeFinished(
- render_view->GetRoutingID(), params.request_id, true, -1, "",
+ render_view->GetRoutingID(),
+ params.request_id,
+ "", // no error
+ -1,
+ GURL(""),
execution_results));
return;
}
@@ -179,11 +183,11 @@ void UserScriptScheduler::ExecuteCodeImpl(
render_view->Send(new ExtensionHostMsg_ExecuteCodeFinished(
render_view->GetRoutingID(),
params.request_id,
- false,
- -1,
ExtensionErrorUtils::FormatErrorMessage(
extension_manifest_errors::kCannotAccessPage,
frame->document().url().spec()),
+ -1,
+ GURL(""),
execution_results));
return;
}
@@ -232,9 +236,9 @@ void UserScriptScheduler::ExecuteCodeImpl(
render_view->Send(new ExtensionHostMsg_ExecuteCodeFinished(
render_view->GetRoutingID(),
params.request_id,
- true,
+ "", // no error
render_view->GetPageId(),
- "",
+ UserScriptSlave::GetDataSourceURLForFrame(frame_),
execution_results));
}
« no previous file with comments | « chrome/renderer/extensions/extension_helper.cc ('k') | chrome/renderer/extensions/user_script_slave.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698