Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: win compile fix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.h ('k') | chrome/browser/extensions/script_badge_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc
index 73749424f4cd4381b1edeec9df148fb692417f45..2e069b65cb5a57a4be5c3006c086785fe7444e8b 100644
--- a/chrome/browser/extensions/api/tabs/tabs.cc
+++ b/chrome/browser/extensions/api/tabs/tabs.cc
@@ -1347,18 +1347,15 @@ void UpdateTabFunction::PopulateResult() {
}
}
-void UpdateTabFunction::OnExecuteCodeFinished(bool success,
- int32 page_id,
- const std::string& error,
+void UpdateTabFunction::OnExecuteCodeFinished(const std::string& error,
+ int32 on_page_id,
+ const GURL& url,
const ListValue& script_result) {
- if (!error.empty()) {
- CHECK(!success);
- error_ = error;
- }
-
- if (success)
+ if (error.empty())
PopulateResult();
- SendResponse(success);
+ else
+ error_ = error;
+ SendResponse(error.empty());
}
bool MoveTabsFunction::RunImpl() {
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.h ('k') | chrome/browser/extensions/script_badge_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698