Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10826136: Fixes chrome_page_zoom::Zoom(). First, correctly retrieves the default zoom level from the user Pro… (Closed)

Created:
8 years, 4 months ago by Kyle Horimoto
Modified:
8 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes chrome_page_zoom::Zoom(). First, correctly retrieves the default zoom level from the user Profile instead of from RendererPreferences. Second, correctly sets the default zoom level when content::PAGE_ZOOM_RESET is passed as the zoom parameter (previously, it just set the zoom to 100% no matter what the default zoom level was). BUG= TBR=jhawkins Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/chrome_page_zoom.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Kyle Horimoto
8 years, 4 months ago (2012-08-03 03:58:47 UTC) #1
Peter Kasting
LGTM
8 years, 4 months ago (2012-08-03 19:11:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10826136/1
8 years, 4 months ago (2012-08-03 19:13:34 UTC) #3
commit-bot: I haz the power
Presubmit check for 10826136-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-03 19:13:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10826136/1
8 years, 4 months ago (2012-08-03 19:14:53 UTC) #5
commit-bot: I haz the power
Try job failure for 10826136-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 19:43:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10826136/1
8 years, 4 months ago (2012-08-03 20:35:03 UTC) #7
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 4 months ago (2012-08-03 20:35:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10826136/1
8 years, 4 months ago (2012-08-03 20:42:44 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 23:19:11 UTC) #10 
Change committed as 149964

Powered by Google App Engine
This is Rietveld 408576698