Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/bookmarks/bookmark_extension_api.cc

Issue 10826127: Coverity: Fix a leak. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_extension_api.cc
diff --git a/chrome/browser/bookmarks/bookmark_extension_api.cc b/chrome/browser/bookmarks/bookmark_extension_api.cc
index 3b422147f3977e90260e8a1ea3de7cc0e0f41498..0ef128ea58e6c5ddfb25eb885923a49e578aef49 100644
--- a/chrome/browser/bookmarks/bookmark_extension_api.cc
+++ b/chrome/browser/bookmarks/bookmark_extension_api.cc
@@ -9,6 +9,7 @@
#include "base/i18n/file_util_icu.h"
#include "base/i18n/time_formatting.h"
#include "base/json/json_writer.h"
+#include "base/memory/scoped_ptr.h"
#include "base/path_service.h"
#include "base/sha1.h"
#include "base/stl_util.h"
@@ -196,8 +197,8 @@ void BookmarkExtensionEventRouter::BookmarkNodeAdded(BookmarkModel* model,
ListValue args;
const BookmarkNode* node = parent->GetChild(index);
args.Append(new StringValue(base::Int64ToString(node->id())));
- BookmarkTreeNode* tree_node =
- bookmark_extension_helpers::GetBookmarkTreeNode(node, false, false);
+ scoped_ptr<BookmarkTreeNode> tree_node(
+ bookmark_extension_helpers::GetBookmarkTreeNode(node, false, false));
args.Append(tree_node->ToValue().release());
std::string json_args;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698