Show the leading Section headline text in PageInfoBubbleView.

chrome/browser/ui/views/page_info_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/page_info_bubble_view.h"
 
 #include <algorithm>
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/certificate_viewer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/toolbar_view.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/ssl_status.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "net/base/x509_certificate.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/base/range/range.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/separator.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/widget/widget.h"
 
 using content::OpenURLParams;
@@ skipping 384 matching lines @@
   x += size.width() + kHGapImageToDescription;
   int w = width - x - kTextPaddingRight;
   y = kVGapToHeadline;
   int headline_height = 0;
   if (!headline_label_->text().empty()) {
     size = headline_label_->GetPreferredSize();
     headline_height = size.height();
     if (!compute_bounds_only)
       headline_label_->SetBounds(x, y, w > 0 ? w : 0, size.height());
     y += size.height();
+
+    // Show the leading headline text by moving the textfield cursor there,
+    // otherwise long headlines may initially show the leading text truncated.
+    // This can only be done after the textfield is initialized with the Widget.
+    if (GetWidget())
+      headline_label_->SelectRange(ui::Range());

[Peter Kasting, 2012/08/03 19:20:37]

I don't think this is the right fix.  Instead, the headline label needs to
either break across lines, or elide.  Either will remove the need for this and
look less broken.

It would be nice if the width of the bubble took the headline text size into
account, so that if it wasn't unreasonably long we'd show it all untruncated.

[msw, 2012/08/03 20:10:19]

This fixes the regression and brings us to parity with M19. I agree with your
thoughts for a better long-term fix, but I think we should land this safe, small
change and request merge to M21.

(FYI, we'd need to add views::Textfield multi-line or eliding/fading support for
your suggestions. A better interim fix to show the whole string might be to make
the Views PageInfoBubble wider, as it is on other platforms).

   } else {
     if (!compute_bounds_only)
       headline_label_->SetBounds(x, y, 0, 0);
   }
   if (w > 0) {
     int height = description_label_->GetHeightForWidth(w);
     if (headline_height == 0 && height < image_height) {
       // Descriptions without headlines that take up less space vertically than
       // the image, should center align against the image.
       y = status_image_->y() + (image_height - height) / 2;
@@ skipping 29 matching lines @@
                                                                 web_contents,
                                                                 url,
                                                                 ssl,
                                                                 show_history,
                                                                 navigator);
   views::BubbleDelegateView::CreateBubble(page_info_bubble);
   page_info_bubble->Show();
 }
 
 }  // namespace chrome