Properly update chromedriver.

tools/testing/perf_testing/run_perf_tests.py

 #!/usr/bin/python
 
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import datetime
 import math             
 import optparse
 import os
@@ skipping 709 matching lines @@
           if not self.test.is_valid_combination(browser, version_name):
             continue
           version = DromaeoTest.DromaeoPerfTester.get_dromaeo_url_query(
               browser, version_name)
           self.test.trace_file = os.path.join(
               'tools', 'testing', 'perf_testing', self.test.result_folder_name,
               'dromaeo-%s-%s-%s' % (self.test.cur_time, browser, version_name))
           self.add_svn_revision_to_trace(self.test.trace_file, browser)
           file_path = '"%s"' % os.path.join(os.getcwd(), dromaeo_path,
               'index-js.html?%s' % version)
+          if platform.system() == 'Windows':
+            file_path = file_path.replace('&', '^&')
+            file_path = file_path.replace('?', '^?')
+            file_path = file_path.replace('|', '^|')
           self.test.test_runner.run_cmd(
               ['python', os.path.join('tools', 'testing', 'run_selenium.py'),
                '--out', file_path, '--browser', browser,
                '--timeout', '900', '--mode', 'dromaeo'], self.test.trace_file,
                append=True)
       # Put default Chromedriver back in.
       self.move_chrome_driver_if_needed('chrome')
 
     @staticmethod
     def get_dromaeo_url_query(browser, version):
@@ skipping 331 matching lines @@
   """Update the set of CLs that do not need additional performance runs.
   Args:
   revision_num: an additional number to be added to the 'done set'
   """
   filename = os.path.join(dirname(abspath(__file__)), 'cached_results.txt')
   if not os.path.exists(filename):
     f = open(filename, 'w')
     results = set()
     pickle.dump(results, f)
     f.close()
-  f = open(filename)
+  f = open(filename, '+r')
   result_set = pickle.load(f)
   if revision_num:
     f.seek(0)
     result_set.add(revision_num)
     pickle.dump(result_set, f)
   f.close()
   return result_set
 
 def main():
   runner = TestRunner()
@@ skipping 23 matching lines @@
             variant = a_test.values_dict[platform_name].keys()[0]
             number_of_results = post_results.get_num_results(benchmark_name,
                 platform_name, variant, revision_num,
                 a_test.file_processor.get_score_type(benchmark_name))
             if number_of_results < 10 and number_of_results >= 0:
               run = runner.run_test_sequence(revision_num=str(revision_num),
                   num_reruns=(10-number_of_results))
               if run == 0:
                 has_run_extra = True
                 results_set = update_set_of_done_cls(revision_num)
-              elif run == -1:
-                # This revision is a broken build. Don't try to run it again.
-                results_set = update_set_of_done_cls(revision_num)
           revision_num -= 1
         # No more extra back-runs to do (for now). Wait for new code.
         time.sleep(200)
   else:
     runner.run_test_sequence()
 
 if __name__ == '__main__':
   main()