Migrate WebRequestRedirectByRegExAction to use RE2

Migrate WebRequestRedirectByRegExAction to use RE2


BUG=112155
TBR=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149852

[battre, 2012-08-02 17:59:31]

PTAL.

Thanks,
Dominic

[Matt Perry, 2012-08-03 09:43:23]

Very cool how simple this change ended up being.

LGTM

[commit-bot: I haz the power, 2012-08-03 12:14:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10826120/1

[commit-bot: I haz the power, 2012-08-03 12:14:34]

Presubmit check for 10826120-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[battre, 2012-08-03 12:32:12]

TBR'ing ben for OWNERs approval for top level changes.

[commit-bot: I haz the power, 2012-08-03 12:32:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10826120/1

[commit-bot: I haz the power, 2012-08-03 13:55:44]

Change committed as 149852

[Joao da Silva, 2012-08-03 14:47:17]

On 2012/08/03 13:55:44, I haz the power (commit-bot) wrote:
> Change committed as 149852

This increased the static_initializers count by 42% (43 to 61 files).
Unfortunately no-one seems to be available to confirm whether this is acceptable
or not given the inclusion of third_party/re2, so this has been reverted.

[Aaron Boodman, 2012-08-04 11:45:54]

On Fri, Aug 3, 2012 at 4:47 PM,  <joaodasilva@chromium.org> wrote:
> On 2012/08/03 13:55:44, I haz the power (commit-bot) wrote:
>>
>> Change committed as 149852
>
>
> This increased the static_initializers count by 42% (43 to 61 files).
> Unfortunately no-one seems to be available to confirm whether this is
> acceptable
> or not given the inclusion of third_party/re2, so this has been reverted.

Bummer. I wonder if rsc would be open to patches to fix these upstream...

- a