Issue 10826100: Make RenderProcessImpl::CreateTransportDIB and RenderProcessImpl::FreeTransportDIB public

Issue 10826100: Make RenderProcessImpl::CreateTransportDIB and RenderProcessImpl::FreeTransportDIB public (Closed)

Created:
8 years, 4 months ago by Fady Samuel

Modified:
8 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make RenderProcessImpl::CreateTransportDIB and RenderProcessImpl::FreeTransportDIB public This code allows for platform-specific ways to allocate and free TransportDIBs. This is needed by the BrowserPlugin. Make them public so that they can be accessed by the BrowserPlugin BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149538

Patch Set 1 #

Patch Set 2 : Patch #

Total comments: 4

Patch Set 3 : Alternative solution: Make CreateTransportDIB/FreeTransportDIB public #

Patch Set 4 : Same as patchset 2 #

Patch Set 5 : Addressed jam@'s comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
M	content/renderer/render_process.h	View	3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/renderer/render_process_impl.h	View	3	2 chunks	+2 lines, -5 lines	0 comments	Download
M	content/test/mock_render_process.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/test/mock_render_process.cc	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download
M	content/test/webrtc_audio_device_test.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jam

patchset 2 is good, just some nits https://chromiumcodereview.appspot.com/10826100/diff/2001/content/test/mock_render_process.cc File content/test/mock_render_process.cc (right): https://chromiumcodereview.appspot.com/10826100/diff/2001/content/test/mock_render_process.cc#newcode61 content/test/mock_render_process.cc:61: nit: one ...

8 years, 4 months ago (2012-08-01 20:44:32 UTC) #1

Fady Samuel

https://chromiumcodereview.appspot.com/10826100/diff/2001/content/test/mock_render_process.cc File content/test/mock_render_process.cc (right): https://chromiumcodereview.appspot.com/10826100/diff/2001/content/test/mock_render_process.cc#newcode61 content/test/mock_render_process.cc:61: On 2012/08/01 20:44:32, John Abd-El-Malek wrote: > nit: one ...

8 years, 4 months ago (2012-08-01 21:07:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10826100/1005

8 years, 4 months ago (2012-08-01 21:11:33 UTC) #4

commit-bot: I haz the power

Try job failure for 10826100-1005 (retry) on linux_rel for step "browser_tests". It's a second try, ...

8 years, 4 months ago (2012-08-01 22:10:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10826100/1005

8 years, 4 months ago (2012-08-01 22:12:55 UTC) #6

Change committed as 149538

Expand Messages | Collapse Messages