Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 10826099: NaCl: Update revision in DEPS, r9336 -> r9341 (Closed)

Created:
8 years, 4 months ago by Mark Seaborn
Modified:
8 years, 4 months ago
Reviewers:
bradn
CC:
chromium-reviews, native-client-reviews_googlegroups.com, Austin Benson, Brad Chen, (google.com) Derek Schuff, eaeltsin, Karl
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r9336 -> r9341 This pulls in the following Native Client changes: r9337: (arbenson) Allow for 64-bit reserved_at_zero parameter r9338: (eaeltsin) Update gdb revision r9339: (kschimpf) Make sure test code generator doesn't generate duplicate definitions r9340: (dschuff) Support -isystem<foo> as well as -isystem <foo> in pnacl driver r9341: (bradchen) Modify 64-bit enuminst to check legal instructions more carefully. BUG=none TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
8 years, 4 months ago (2012-08-01 20:30:17 UTC) #1
bradn
Lgtm -BradN Sent from my phone. On Aug 1, 2012 1:30 PM, <mseaborn@chromium.org> wrote: > ...
8 years, 4 months ago (2012-08-01 21:11:06 UTC) #2
bradn
8 years, 4 months ago (2012-08-01 21:11:08 UTC) #3
Lgtm

-BradN
Sent from my phone.
On Aug 1, 2012 1:30 PM, <mseaborn@chromium.org> wrote:

> Reviewers: bradn,
>
> Description:
> NaCl: Update revision in DEPS, r9336 -> r9341
>
> This pulls in the following Native Client changes:
>
> r9337: (arbenson) Allow for 64-bit reserved_at_zero parameter
> r9338: (eaeltsin) Update gdb revision
> r9339: (kschimpf) Make sure test code generator doesn't generate duplicate
> definitions
> r9340: (dschuff) Support -isystem<foo> as well as -isystem <foo> in pnacl
> driver
> r9341: (bradchen) Modify 64-bit enuminst to check legal instructions more
> carefully.
>
> BUG=none
> TEST=nacl_integration
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10826099/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index 27e4b76ad77ef683d3827f9ee2d9f7**62be1b2a54..**
> 42317ea0ff6e96c39ef688ce90140e**6d9cae7dc8 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -12,10 +12,10 @@ vars = {
>    "chromium_git": "http://git.chromium.org/git",
>    "chromiumos_git":
"http://git.chromium.org/**chromiumos<http://git.chromium.org/chromiumos>
> ",
>    "swig_revision": "69281",
> -  "nacl_revision": "9336",
> +  "nacl_revision": "9341",
>    # After changing nacl_revision, run 'glient sync' and check
> native_client/DEPS
>    # to update other nacl_*_revision's.
> -  "nacl_tools_revision": "9286",  # native_client/DEPS: tools_rev
> +  "nacl_tools_revision": "9330",  # native_client/DEPS: tools_rev
>    "gtm_revision": "534",
>
>    "libjingle_revision": "163",
>
>
>

Powered by Google App Engine
This is Rietveld 408576698