Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: vm/flow_graph_optimizer.cc

Issue 10826097: Use explicit push-argument for InstanceSetter instruction. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/flow_graph_builder.cc ('k') | vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_optimizer.cc
===================================================================
--- vm/flow_graph_optimizer.cc (revision 10115)
+++ vm/flow_graph_optimizer.cc (working copy)
@@ -432,11 +432,15 @@
ASSERT(!field.IsNull());
StoreInstanceFieldComp* store = new StoreInstanceFieldComp(
field,
- comp->InputAt(0),
- comp->InputAt(1),
+ comp->ArgumentAt(0)->value(),
+ comp->ArgumentAt(1)->value(),
comp);
store->set_ic_data(comp->ic_data());
instr->set_computation(store);
+ // Remove original push arguments.
+ for (intptr_t i = 0; i < comp->ArgumentCount(); ++i) {
+ comp->ArgumentAt(i)->RemoveFromGraph();
+ }
return true;
}
@@ -516,8 +520,6 @@
comp->set_operands_class_id(kSmi);
} else if (HasOnlyTwoDouble(ic_data)) {
comp->set_operands_class_id(kDouble);
- } else {
- return;
}
}
« no previous file with comments | « vm/flow_graph_builder.cc ('k') | vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698