Use explicit push-argument for InstanceSetter instruction.

vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
@@ skipping 1770 matching lines @@
   arguments->Add(push_receiver);
   const String& name =
       String::ZoneHandle(Field::GetterSymbol(node->field_name()));
   InstanceCallComp* call = new InstanceCallComp(
       node->token_pos(), owner()->try_index(), name, Token::kGET,
       arguments, Array::ZoneHandle(), 1);
   ReturnComputation(call);
 }
 
 
-void EffectGraphVisitor::BuildInstanceSetterValues(
-    InstanceSetterNode* node, Value** receiver, Value** value) {
+void EffectGraphVisitor::BuildInstanceSetterArguments(
+    InstanceSetterNode* node,
+    ZoneGrowableArray<PushArgumentInstr*>* arguments,
+    bool result_is_needed) {
   ValueGraphVisitor for_receiver(owner(), temp_index());
   node->receiver()->Visit(&for_receiver);
   Append(for_receiver);
-  ValueGraphVisitor for_value(owner(), for_receiver.temp_index());
+  arguments->Add(PushArgument(for_receiver.value()));
+
+  ValueGraphVisitor for_value(owner(), temp_index());
   node->value()->Visit(&for_value);
   Append(for_value);
-  *receiver = for_receiver.value();
-  *value = for_value.value();
+
+  Value* value = NULL;
+  if (result_is_needed) {
+    value = Bind(
+        BuildStoreLocal(*owner()->parsed_function().expression_temp_var(),
+                        for_value.value()));
+  } else {
+    value = for_value.value();
+  }
+  arguments->Add(PushArgument(value));
 }
 
 
 void EffectGraphVisitor::VisitInstanceSetterNode(InstanceSetterNode* node) {
-  Value *receiver, *value;
-  BuildInstanceSetterValues(node, &receiver, &value);
+  ZoneGrowableArray<PushArgumentInstr*>* arguments =
+      new ZoneGrowableArray<PushArgumentInstr*>(2);
+  BuildInstanceSetterArguments(node, arguments, false);  // Value not used.
   InstanceSetterComp* setter =
       new InstanceSetterComp(node->token_pos(),
                              owner()->try_index(),
                              node->field_name(),
-                             receiver,
-                             value);
+                             arguments);
   ReturnComputation(setter);
 }
 
 
 void ValueGraphVisitor::VisitInstanceSetterNode(InstanceSetterNode* node) {
-  Value *receiver, *value;
-  BuildInstanceSetterValues(node, &receiver, &value);
-  Value* saved_value = Bind(
-      BuildStoreLocal(*owner()->parsed_function().expression_temp_var(),
-                      value));
+  ZoneGrowableArray<PushArgumentInstr*>* arguments =
+      new ZoneGrowableArray<PushArgumentInstr*>(2);
+  BuildInstanceSetterArguments(node, arguments, true);  // Value used.
   Do(new InstanceSetterComp(node->token_pos(),
                             owner()->try_index(),
                             node->field_name(),
-                            receiver,
-                            saved_value));
+                            arguments));
   ReturnComputation(
        BuildLoadLocal(*owner()->parsed_function().expression_temp_var()));
 }
 
 
 void EffectGraphVisitor::VisitStaticGetterNode(StaticGetterNode* node) {
   const String& getter_name =
       String::Handle(Field::GetterName(node->field_name()));
   const Function& getter_function =
       Function::ZoneHandle(node->cls().LookupStaticFunction(getter_name));
@@ skipping 911 matching lines @@
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len));
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart