Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: runtime/vm/parser_test.cc

Issue 10826090: Optimize away most implicit const getter functions (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser_test.cc
===================================================================
--- runtime/vm/parser_test.cc (revision 10092)
+++ runtime/vm/parser_test.cc (working copy)
@@ -130,18 +130,7 @@
CheckField(lib, "A", "f4", false, true);
CheckField(lib, "A", "s1", true, false);
CheckField(lib, "A", "s2", true, false);
- // No field entries are added for static const fields.
- String& fieldname = String::Handle(String::New("s3"));
- const String& classname = String::Handle(Symbols::New("A"));
- const Class& cls = Class::Handle(lib.LookupClass(classname));
- const Field& field = Field::Handle(cls.LookupStaticField(fieldname));
- EXPECT(!field.IsNull());
- Object& val = Object::Handle(field.value());
- // The static const field initializer is not evaluated and the field
- // value is not initialized until the field is referenced by code that
- // is compiled.
- EXPECT(val.raw() == Object::sentinel());
-
+ CheckField(lib, "A", "s3", true, true);
CheckFunction(lib, "A", "bar", true);
CheckFunction(lib, "A", "foo", true);
}
« no previous file with comments | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698