Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 10826084: Fixed SelectFile parameter for the Wallpaper chooser (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev
Modified:
8 years, 4 months ago
Reviewers:
csilv, bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fixed SelectFile parameter for the Wallpaper chooser BUG=137594 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vladislav Kaznacheev
Hi Biao, Please review this small patch. I am changing the way the FileTypeInfo structure ...
8 years, 4 months ago (2012-07-31 15:01:09 UTC) #1
bshe
On 2012/07/31 15:01:09, Vladislav Kaznacheev wrote: > Hi Biao, > > Please review this small ...
8 years, 4 months ago (2012-07-31 15:08:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10826084/1
8 years, 4 months ago (2012-07-31 15:16:15 UTC) #3
commit-bot: I haz the power
Presubmit check for 10826084-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 15:16:17 UTC) #4
Vladislav Kaznacheev
Adding an OWNER of chrome/browser/ui/webui/options2
8 years, 4 months ago (2012-07-31 15:18:58 UTC) #5
csilv
lgtm
8 years, 4 months ago (2012-07-31 17:47:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10826084/1
8 years, 4 months ago (2012-07-31 20:46:18 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 22:13:44 UTC) #8
Change committed as 149292

Powered by Google App Engine
This is Rietveld 408576698