Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 10826082: Replace yellow outline from focused searchbox with blue border. Replace yellow outlines with blue o… (Closed)

Created:
8 years, 4 months ago by Oleg Eterevsky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Replace yellow outline from focused searchbox with blue border. Replace yellow outlines with blue ones for buttons and rename input. Replace the default search cancel button with the custom one. BUG=137995, 137996, 137997 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149182

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (0 generated)
Oleg Eterevsky
8 years, 4 months ago (2012-07-31 13:47:27 UTC) #1
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10826082/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/10826082/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode484 chrome/browser/resources/file_manager/css/file_manager.css:484: height: 16px; it might be cleaner to set background-position: ...
8 years, 4 months ago (2012-07-31 13:55:57 UTC) #2
Vladislav Kaznacheev
lgtm
8 years, 4 months ago (2012-07-31 14:10:22 UTC) #3
Oleg Eterevsky
https://chromiumcodereview.appspot.com/10826082/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/10826082/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode484 chrome/browser/resources/file_manager/css/file_manager.css:484: height: 16px; On 2012/07/31 13:55:57, Vladislav Kaznacheev wrote: > ...
8 years, 4 months ago (2012-07-31 14:10:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/10826082/1
8 years, 4 months ago (2012-07-31 14:11:02 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 14:11:04 UTC) #6
Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 404: Not Found

Powered by Google App Engine
This is Rietveld 408576698