Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10826076: [Chromoting] Remove check for too many args from signing script. (Closed)

Created:
8 years, 4 months ago by garykac
Modified:
8 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Remove check for too many args from signing script. Purpose of this change is to help future-proof the script. Since old versions of this script may be run when signing old builds, removing this check for too many args allows us to add new params on the calling side without breaking old builds. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/host/installer/mac/do_signing.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
garykac
8 years, 4 months ago (2012-07-31 00:09:47 UTC) #1
Jamie
8 years, 4 months ago (2012-07-31 00:11:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698