gpu/command_buffer/service/program_manager.cc - Issue 10826073: Added null check for shader source when compiling, and fixed re-caching behavior to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/program_manager.cc

Issue 10826073: Added null check for shader source when compiling, and fixed re-caching behavior to spec (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/program_manager.cc

diff --git a/gpu/command_buffer/service/program_manager.cc b/gpu/command_buffer/service/program_manager.cc

index 21b923802c064a69f2d7f423c61e171cb58ec59a..b109be947696aa4e88461ba1801bd97a049adc0c 100644

--- a/gpu/command_buffer/service/program_manager.cc

+++ b/gpu/command_buffer/service/program_manager.cc

@@ -382,7 +382,8 @@ void ProgramManager::DoCompileShader(ShaderManager::ShaderInfo* info,

ShaderTranslator* translator,

FeatureInfo* feature_info) {

if (program_cache_ &&

- program_cache_->GetShaderCompilationStatus(*info->source()) ==

+ program_cache_->GetShaderCompilationStatus(info->source() ?

+ *info->source() : "") ==

ProgramCache::COMPILATION_SUCCEEDED) {

info->SetStatus(true, "", translator);

info->FlagSourceAsCompiled(false);

« no previous file with comments | « gpu/command_buffer/service/memory_program_cache_unittest.cc ('k') | no next file » | no next file with comments »