Issue 10826073: Added null check for shader source when compiling, and fixed re-caching behavior to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826073: Added null check for shader source when compiling, and fixed re-caching behavior to spec (Closed)

Created:
8 years, 4 months ago by dmurph

Modified:
8 years, 4 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium, scheib

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Added null check for shader source when compiling, and fixed re-caching behavior to spec BUG=139711, 139681 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149104

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -13 lines)			Patch
M	gpu/command_buffer/service/memory_program_cache.cc	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	gpu/command_buffer/service/memory_program_cache_unittest.cc	View	2 chunks	+33 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

dmurph

The top changes with buffer_size to length is to clean up the code a little ...

8 years, 4 months ago (2012-07-30 22:06:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmurph@chromium.org/10826073/1

8 years, 4 months ago (2012-07-30 23:42:41 UTC) #3

Change committed as 149104