Added schemas to policy templates.

Added schemas to policy templates.

BUG=108997
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149178

[Joao da Silva, 2012-07-30 15:10:45]

This is tedious to check 1 by 1, but you can trust 1) the syntax checker and 2)
my vim macro :-) Please have a look, thanks!

[Mattias Nissler (ping if slow), 2012-07-31 11:46:34]

LGTM, but I'd like to take another look if you follow the suggestion.

http://codereview.chromium.org/10826061/diff/1/chrome/app/policy/syntax_check...
File chrome/app/policy/syntax_check_policy_template_json.py (right):

http://codereview.chromium.org/10826061/diff/1/chrome/app/policy/syntax_check...
chrome/app/policy/syntax_check_policy_template_json.py:24: 'int': 'integer',
Suggestion: You could just put the entire expected schema dictionary here?
Python seems to compare dictionaries just fine.

http://codereview.chromium.org/10826061/diff/1/chrome/app/policy/syntax_check...
chrome/app/policy/syntax_check_policy_template_json.py:132: policy.get('name'))
nit: Elsewhere in this file, the continuation is aligned at the opening
parenthesis.

[Joao da Silva, 2012-07-31 12:56:48]

Thanks for the review!

https://chromiumcodereview.appspot.com/10826061/diff/1/chrome/app/policy/synt...
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://chromiumcodereview.appspot.com/10826061/diff/1/chrome/app/policy/synt...
chrome/app/policy/syntax_check_policy_template_json.py:24: 'int': 'integer',
On 2012/07/31 11:46:34, Mattias Nissler wrote:
> Suggestion: You could just put the entire expected schema dictionary here?
> Python seems to compare dictionaries just fine.

'dicts' and the '-enums' have extra fields that aren't always the same, so a
simple equality test would fail on those cases. Testing that the 'schema' is a
subset of an expected dictionary would work, but I couldn't find anything in the
python libraries that does that.

Shouldn't take too much to write a custom function for that, but this is
transitional code anyway, so I'll pass :-)

https://chromiumcodereview.appspot.com/10826061/diff/1/chrome/app/policy/synt...
chrome/app/policy/syntax_check_policy_template_json.py:132: policy.get('name'))
On 2012/07/31 11:46:34, Mattias Nissler wrote:
> nit: Elsewhere in this file, the continuation is aligned at the opening
> parenthesis.

Done.

[commit-bot: I haz the power, 2012-07-31 12:57:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10826061/8002

[commit-bot: I haz the power, 2012-07-31 14:13:28]

Change committed as 149178