Convert the sub-rectangle for GL functions from the views coordinate to the OpenGL coordinate.

Convert the sub-rectangle for GL functions from the views coordinate to the OpenGL coordinate.

BUG=118571
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148882

[mazda, 2012-07-27 23:36:54]

Hi Nico,

Could you review this change?
It turned out this conversion was necessary...

[Nico, 2012-07-27 23:41:24]

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:518:
GetViewBounds().height() - src_subrect.y() - src_subrect.height());
- src_subrect.bottom() is a bit shorter and does the same thing.


Don't you need to scale by the scale factor here too?

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:839:
GetViewBounds().height() - src_subrect.y() - src_subrect.height());
Same here.

[mazda, 2012-07-28 00:31:44]

Thank you for the review.
I addressed the comments.

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:518:
GetViewBounds().height() - src_subrect.y() - src_subrect.height());
On 2012/07/27 23:41:24, Nico wrote:
> - src_subrect.bottom() is a bit shorter and does the same thing.
> 
> 
> Don't you need to scale by the scale factor here too?

Done.

Scaling is done by ConvertRectToPixel below.

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10826054/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:839:
GetViewBounds().height() - src_subrect.y() - src_subrect.height());
On 2012/07/27 23:41:24, Nico wrote:
> Same here.

Done.

[Nico, 2012-07-28 01:40:19]

lgtm

http://codereview.chromium.org/10826054/diff/7001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10826054/diff/7001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:840: gfx::Rect
src_pixel_subrect = src_gl_subrect.Scale(scale);
nit: src_pixel_gl_subrect

[mazda, 2012-07-28 01:49:07]

http://codereview.chromium.org/10826054/diff/7001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10826054/diff/7001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:840: gfx::Rect
src_pixel_subrect = src_gl_subrect.Scale(scale);
On 2012/07/28 01:40:19, Nico wrote:
> nit: src_pixel_gl_subrect

Done.

[commit-bot: I haz the power, 2012-07-28 01:49:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10826054/11001

[commit-bot: I haz the power, 2012-07-28 04:04:19]

Change committed as 148882