Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10826044: Remove call to IsTryingToQuit from BrowserListImpl::SetLastActive (Closed)

Created:
8 years, 4 months ago by benwells
Modified:
8 years, 4 months ago
Reviewers:
sail, sky
CC:
chromium-reviews, rginda+watch_chromium.org
Visibility:
Public.

Description

Remove call to IsTryingToQuit from BrowserListImpl::SetLastActive Instead the profile manager watches notifications to determine this. BUG=130456 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150743

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benwells
8 years, 4 months ago (2012-07-27 11:19:49 UTC) #1
sail
LGTM CL description doesn't match code http://codereview.chromium.org/10826044/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): http://codereview.chromium.org/10826044/diff/1/chrome/browser/profiles/profile_manager.cc#newcode642 chrome/browser/profiles/profile_manager.cc:642: if (profile_manager_->closing_all_browsers_) this ...
8 years, 4 months ago (2012-07-27 16:58:40 UTC) #2
benwells
Description updated / comment added. sky: care to take a look?
8 years, 4 months ago (2012-07-30 03:56:41 UTC) #3
sky
LGTM, as long as you inspected all overrides of OnBrowserSetLastActive to make sure there aren't ...
8 years, 4 months ago (2012-08-02 20:47:06 UTC) #4
benwells
On 2012/08/02 20:47:06, sky wrote: > LGTM, as long as you inspected all overrides of ...
8 years, 4 months ago (2012-08-09 03:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10826044/7001
8 years, 4 months ago (2012-08-09 03:59:23 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 05:22:40 UTC) #7
Change committed as 150743

Powered by Google App Engine
This is Rietveld 408576698