Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 10826039: Support 64-bit reserved_at_zero value chrome-side (Closed)

Created:
8 years, 4 months ago by Austin Benson
Modified:
8 years, 4 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl: Support 64-bit reserved_at_zero value This change will make the x86-32 sandbox on Linux non-zero-based until the change at http://codereview.chromium.org/10832040/ is committed in Chromium. Also, on Atom, performance will be temporarily reduced but not broken. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2927 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/app/nacl_fork_delegate_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/nacl/nacl_helper_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Austin Benson
8 years, 4 months ago (2012-07-27 22:25:12 UTC) #1
Mark Seaborn
LGTM, but as with http://codereview.chromium.org/10832040/, please add a note to the commit message to warn ...
8 years, 4 months ago (2012-07-30 21:14:56 UTC) #2
Austin Benson
Message updated. Going to commit this one first.
8 years, 4 months ago (2012-07-30 22:24:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arbenson@google.com/10826039/1
8 years, 4 months ago (2012-07-30 22:25:40 UTC) #4
commit-bot: I haz the power
Presubmit check for 10826039-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 22:25:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arbenson@google.com/10826039/1
8 years, 4 months ago (2012-07-31 23:07:54 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 00:36:33 UTC) #7
Change committed as 149333

Powered by Google App Engine
This is Rietveld 408576698