Extensions Docs Server: Fix zipper

Extensions Docs Server: Fix zipper

The ExampleZipper was getting caught on unicode characters. I added a parameter
to Read in FileSystem that will return the files without converting to unicode.

BUG=131095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148980

[cduvall, 2012-07-26 22:36:03]

Fix for problem chebert found.

[not at google - send to devlin, 2012-07-27 04:54:36]

Nice find.

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/example_zipper.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/example_zipper.py:27: for name, file_ in
self._file_system.Read(files, False).Get().iteritems():
name to optional arguments plz

Read(files, binary=True)

also I preferred the old way of having "contents" in the name; makes it clear
that it's the file's contents not its handle. Maybe "file_contents"?

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/file_system.py:24: def Read(self, paths,
process=True):
always prefer false-by-default values.

how about binary=False

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/local_file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/local_file_system.py:22: if process:
Safer to make it clear that f is only being read once by assigning to variable
first.

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/memcache_file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/memcache_file_system.py:48: new_items =
self._file_system.Read(uncached, process).Get()
process=process

or rather, binary=binary

[cduvall, 2012-07-27 18:12:28]

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/example_zipper.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/example_zipper.py:27: for name, file_ in
self._file_system.Read(files, False).Get().iteritems():
On 2012/07/27 04:54:36, kalman wrote:
> name to optional arguments plz
> 
> Read(files, binary=True)
> 
> also I preferred the old way of having "contents" in the name; makes it clear
> that it's the file's contents not its handle. Maybe "file_contents"?

Done.

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/file_system.py:24: def Read(self, paths,
process=True):
On 2012/07/27 04:54:36, kalman wrote:
> always prefer false-by-default values.
> 
> how about binary=False

Done.

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/local_file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/local_file_system.py:22: if process:
On 2012/07/27 04:54:36, kalman wrote:
> Safer to make it clear that f is only being read once by assigning to variable
> first.

Done.

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/memcache_file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/memcache_file_system.py:48: new_items =
self._file_system.Read(uncached, process).Get()
On 2012/07/27 04:54:36, kalman wrote:
> process=process
> 
> or rather, binary=binary

Done.

[not at google - send to devlin, 2012-07-30 08:21:18]

lgtm

https://chromiumcodereview.appspot.com/10826037/diff/7001/chrome/common/exten...
File chrome/common/extensions/docs/server2/file_system.py (right):

https://chromiumcodereview.appspot.com/10826037/diff/7001/chrome/common/exten...
chrome/common/extensions/docs/server2/file_system.py:27: directory, and a list
of files in the directory is mapped to the path.
Could you add like

If binary=False, the contents of each file will be unicode parsed as utf-8, and
failing that as latin-1 (some extension docs use latin-1). If binary=True then
the contents will be a str.

[cduvall, 2012-07-30 18:27:31]

http://codereview.chromium.org/10826037/diff/7001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/file_system.py (right):

http://codereview.chromium.org/10826037/diff/7001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/file_system.py:27: directory, and a list
of files in the directory is mapped to the path.
On 2012/07/30 08:21:19, kalman wrote:
> Could you add like
> 
> If binary=False, the contents of each file will be unicode parsed as utf-8,
and
> failing that as latin-1 (some extension docs use latin-1). If binary=True then
> the contents will be a str.

Done.