Issue 10826035: Fix error syncing to LKGR due to misparsing of Cygwin git-svn output.

Issue 10826035: Fix error syncing to LKGR due to misparsing of Cygwin git-svn output. (Closed)

Created:
8 years, 5 months ago by Mike Wittman

Modified:
8 years, 4 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix error syncing to LKGR due to misparsing of Cygwin git-svn output. BUG=138104 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150952

Patch Set 2 : Adding test for git-svn SHA1 output parsing #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	scm.py	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download
	M	tests/scm_unittest.py	View	1	2 chunks	+11 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

On 2012/08/08 18:49:16, Mike Wittman wrote: > Hi Dirk, PTAL when you have the chance. ...

8 years, 4 months ago (2012-08-08 20:46:14 UTC) #2

Mike Wittman

Sure. I've factored out the parsing and added a test function against observed outputs on ...

8 years, 4 months ago (2012-08-09 18:30:36 UTC) #3

Dirk Pranke

lgtm. http://codereview.chromium.org/10826035/diff/4001/tests/scm_unittest.py File tests/scm_unittest.py (right): http://codereview.chromium.org/10826035/diff/4001/tests/scm_unittest.py#newcode176 tests/scm_unittest.py:176: cygwin_output = test_sha1 + '\n\033[?1034h' Great, this is ...

8 years, 4 months ago (2012-08-09 18:52:23 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/10826035/4001

8 years, 4 months ago (2012-08-10 00:25:49 UTC) #5

Change committed as 150952

Expand Messages | Collapse Messages