Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: src/hydrogen.h

Issue 10826028: Cleaned up Hydrogen function signatures related to property access. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed feedback Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index 28f61c5aebb7a9365ed697260182228cd6ec5f5e..f4c15c7812f82aa559f28306b8360dadd919d874 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1089,13 +1089,13 @@ class HGraphBuilder: public AstVisitor {
HInstruction* BuildIncrement(bool returns_original_input,
CountOperation* expr);
HLoadNamedField* BuildLoadNamedField(HValue* object,
- Property* expr,
- Handle<Map> type,
+ Handle<Map> map,
LookupResult* result,
bool smi_and_map_check);
- HInstruction* BuildLoadNamedGeneric(HValue* object, Property* expr);
- HInstruction* BuildLoadKeyedGeneric(HValue* object,
- HValue* key);
+ HInstruction* BuildLoadNamedGeneric(HValue* object,
+ Handle<String> name,
+ Property* expr);
+ HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key);
HInstruction* BuildExternalArrayElementAccess(
HValue* external_elements,
HValue* checked_key,
@@ -1147,29 +1147,27 @@ class HGraphBuilder: public AstVisitor {
bool is_store,
bool* has_side_effects);
- HInstruction* BuildCallGetter(HValue* obj,
- Property* expr,
+ HInstruction* BuildCallGetter(HValue* object,
Handle<Map> map,
- Handle<Object> callback,
+ Handle<AccessorPair> accessors,
Handle<JSObject> holder);
HInstruction* BuildLoadNamed(HValue* object,
- Property* prop,
- Handle<Map> map,
- Handle<String> name);
+ Handle<String> name,
+ Property* expr,
+ Handle<Map> map);
HInstruction* BuildCallSetter(HValue* object,
- Handle<String> name,
HValue* value,
Handle<Map> map,
- Handle<Object> callback,
+ Handle<AccessorPair> accessors,
Handle<JSObject> holder);
HInstruction* BuildStoreNamed(HValue* object,
+ Handle<String> name,
HValue* value,
- Handle<Map> type,
- Expression* key);
+ Handle<Map> map);
HInstruction* BuildStoreNamedField(HValue* object,
Handle<String> name,
HValue* value,
- Handle<Map> type,
+ Handle<Map> map,
LookupResult* lookup,
bool smi_and_map_check);
HInstruction* BuildStoreNamedGeneric(HValue* object,
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698