Cleaned up Hydrogen function signatures related to property access.

Cleaned up Hydrogen function signatures related to property access.

This is a refactoring-only CL and the first one in a series for enabling
inlining of accessors. The naming and argument order has been unified a bit, and
some tests have been pushed to the caller in order to get a simpler
signature. Note that the latter temporarily introduces some code redundancy, but
this will be cleaned up in one of the next CLs.

Committed: https://code.google.com/p/v8/source/detail?r=12198

[Michael Starzinger, 2012-07-26 08:36:29]

LGTM (with one nit).

http://codereview.chromium.org/10826028/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10826028/diff/1/src/hydrogen.cc#newcode4768
src/hydrogen.cc:4768: Handle<String>::cast(property->key()->handle());
Consider using property->key()->AsPropertyName() here.

http://codereview.chromium.org/10826028/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/10826028/diff/1/src/hydrogen.h#newcode1152
src/hydrogen.h:1152: Handle<AccessorPair> accessors,
I like that, much cleaner!

[Sven Panne, 2012-07-26 08:50:09]

Landing...

http://codereview.chromium.org/10826028/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10826028/diff/1/src/hydrogen.cc#newcode4768
src/hydrogen.cc:4768: Handle<String>::cast(property->key()->handle());
On 2012/07/26 08:36:29, Michael Starzinger wrote:
> Consider using property->key()->AsPropertyName() here.

Good point, it seems that I start getting lost in our impressive casting
machinery... :-P