Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 10826027: mac: -[NSTableColumn initWithIdentifier:] takes NSString instead of id with the 10.7 sdk. (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, yoshiki+watch_chromium.org
Visibility:
Public.

Description

mac: -[NSTableColumn initWithIdentifier:] takes NSString instead of id with the 10.7 sdk. BUG=136844 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/task_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 5 months ago (2012-07-26 05:50:16 UTC) #1
Robert Sesek
lgtm
8 years, 5 months ago (2012-07-26 10:10:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10826027/1
8 years, 5 months ago (2012-07-26 15:16:26 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 16:35:39 UTC) #4
Change committed as 148562

Powered by Google App Engine
This is Rietveld 408576698