Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 10826026: Add a printing resource (as a new style resource) to fetch the default print settings (Closed)

Created:
8 years, 5 months ago by raymes
Modified:
8 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

This adds the plugin side of the resource only, as well as a unittest. BUG=138333 TEST=Ran new unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155352

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -81 lines) Patch
M content/renderer/pepper/pepper_in_process_resource_creation.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_in_process_resource_creation.cc View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M ppapi/api/dev/ppb_printing_dev.idl View 1 2 1 chunk +32 lines, -4 lines 0 comments Download
M ppapi/c/dev/ppb_printing_dev.h View 1 2 2 chunks +34 lines, -6 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 3 4 5 2 chunks +0 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 3 4 5 3 chunks +0 lines, -38 lines 0 comments Download
A ppapi/proxy/printing_resource.h View 1 2 3 4 5 1 chunk +52 lines, -0 lines 0 comments Download
A ppapi/proxy/printing_resource.cc View 1 2 3 4 5 1 chunk +71 lines, -0 lines 0 comments Download
A ppapi/proxy/printing_resource_unittest.cc View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 3 4 5 2 chunks +0 lines, -6 lines 0 comments Download
A ppapi/thunk/ppb_printing_api.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_printing_thunk.cc View 1 2 chunks +53 lines, -7 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
raymes
This is the plugin side only. No hurry to review. Host side is coming in ...
8 years, 4 months ago (2012-07-29 15:54:30 UTC) #1
raymes
Happy to have someone else look at it if you're too busy. The host side ...
8 years, 3 months ago (2012-09-06 19:19:29 UTC) #2
brettw
Oh, sorry. This fell off my radar. will look now.
8 years, 3 months ago (2012-09-06 20:17:23 UTC) #3
brettw
lgtm
8 years, 3 months ago (2012-09-06 20:27:19 UTC) #4
raymes
Np I was waiting for you to hook up the browser stuff anyway :) On ...
8 years, 3 months ago (2012-09-06 20:27:35 UTC) #5
brettw
If you want to start on the browser side before my gamepad patch goes in, ...
8 years, 3 months ago (2012-09-06 20:29:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10826026/18003
8 years, 3 months ago (2012-09-06 22:09:10 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 07:11:07 UTC) #8
Change committed as 155352

Powered by Google App Engine
This is Rietveld 408576698