Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 10826014: Add a clarifying comment to the memory layout navigation. (Inspired by Coverity CID 100022) (Closed)

Created:
8 years, 5 months ago by Greg Billock
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add a clarifying comment to the memory layout navigation. (Inspired by Coverity CID 100022) R=tommi@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148412

Patch Set 1 #

Total comments: 2

Patch Set 2 : mapping_.view() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M courgette/memory_allocator.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Greg Billock
8 years, 5 months ago (2012-07-25 18:10:16 UTC) #1
tommi (sloooow) - chröme
lgtm https://chromiumcodereview.appspot.com/10826014/diff/1/courgette/memory_allocator.cc File courgette/memory_allocator.cc (right): https://chromiumcodereview.appspot.com/10826014/diff/1/courgette/memory_allocator.cc#newcode139 courgette/memory_allocator.cc:139: // go past it. (See Initialize()). Ah, nice! ...
8 years, 5 months ago (2012-07-25 19:04:05 UTC) #2
Greg Billock
https://chromiumcodereview.appspot.com/10826014/diff/1/courgette/memory_allocator.cc File courgette/memory_allocator.cc (right): https://chromiumcodereview.appspot.com/10826014/diff/1/courgette/memory_allocator.cc#newcode139 courgette/memory_allocator.cc:139: // go past it. (See Initialize()). On 2012/07/25 19:04:05, ...
8 years, 5 months ago (2012-07-25 20:12:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10826014/5001
8 years, 5 months ago (2012-07-25 20:12:34 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 21:26:14 UTC) #5
Change committed as 148412

Powered by Google App Engine
This is Rietveld 408576698