Issue 10826005: Don't warp mouse if the cursor is locked.

Issue 10826005: Don't warp mouse if the cursor is locked. (Closed)

Created:
8 years, 5 months ago by oshima

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Yusuke Sato, mazda

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't warp mouse if the cursor is locked, for now. We probably want to change this for window dragging and/or drag&drop. BUG=123160 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148300

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	ash/display/mouse_cursor_event_filter.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
	M	ui/aura/cursor_manager.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10826005/diff/1/ui/aura/cursor_manager.cc File ui/aura/cursor_manager.cc (right): http://codereview.chromium.org/10826005/diff/1/ui/aura/cursor_manager.cc#newcode28 ui/aura/cursor_manager.cc:28: bool CursorManager::IsCursorLocked() { const and inline it.

8 years, 5 months ago (2012-07-25 04:29:47 UTC) #3

oshima

http://codereview.chromium.org/10826005/diff/1/ui/aura/cursor_manager.cc File ui/aura/cursor_manager.cc (right): http://codereview.chromium.org/10826005/diff/1/ui/aura/cursor_manager.cc#newcode28 ui/aura/cursor_manager.cc:28: bool CursorManager::IsCursorLocked() { On 2012/07/25 04:29:47, sky wrote: > ...

8 years, 5 months ago (2012-07-25 05:33:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10826005/7001

8 years, 5 months ago (2012-07-25 05:33:58 UTC) #5

Change committed as 148300

Expand Messages | Collapse Messages