Record device scale factor in the metrics log

Record device scale factor in the metrics log

BUG=144016
Committed: https://code.google.com/p/gyp/source/detail?r=152719

[Nico, 2012-08-21 22:18:13]

I have no idea what I'm doing.

[Nico, 2012-08-21 22:42:38]

mpearson told me to remove the xml bit, so I did that.

[Nico, 2012-08-21 22:56:56]

Also, are there any issues with making the new field a float? Can dremel do
float histograms, for example?

[Ilya Sherman, 2012-08-22 00:40:59]

LGTM

On 2012/08/21 22:56:56, Nico wrote:
> Also, are there any issues with making the new field a float? Can dremel do
> float histograms, for example?

It looks like dremel does support querying over float values, but only for exact
values.  So, 3.0 and 3.000000000001 would be different values for dremel.  If
that's fine, then using a float shouldn't cause any problems.

https://chromiumcodereview.appspot.com/10825485/diff/3001/chrome/browser/metr...
File chrome/browser/metrics/metrics_log_unittest.cc (right):

https://chromiumcodereview.appspot.com/10825485/diff/3001/chrome/browser/metr...
chrome/browser/metrics/metrics_log_unittest.cc:130: // of this call.
Can you add the appropriate EXPECT check here to verify that the screen scale
factor got set correctly?

https://chromiumcodereview.appspot.com/10825485/diff/3001/chrome/common/metri...
File chrome/common/metrics/proto/system_profile.proto (right):

https://chromiumcodereview.appspot.com/10825485/diff/3001/chrome/common/metri...
chrome/common/metrics/proto/system_profile.proto:102: optional float
primary_screen_scale_factor = 12;
Keep in mind that you'll also need to update this protocol buffer in the
internal repo, for decoding.

[Nico, 2012-08-22 01:17:47]

Thanks. I added a test.

Will the new field be ignored until the internal proto is updated? (Just
curious, I'll send you a CL for that right now)

[commit-bot: I haz the power, 2012-08-22 01:20:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10825485/4005

[commit-bot: I haz the power, 2012-08-22 02:14:45]

Try job failure for 10825485-4005 (retry) on win for step "runhooks" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[Ilya Sherman, 2012-08-22 02:45:39]

On 2012/08/22 01:17:47, Nico wrote:
> Thanks. I added a test.
> 
> Will the new field be ignored until the internal proto is updated? (Just
> curious, I'll send you a CL for that right now)

Aye, the new field will be ignored until the protos are in sync.

[commit-bot: I haz the power, 2012-08-22 03:15:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10825485/4005