Issue 10825472: Revert r12258, r12300 and r12302 (global regexp).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825472: Revert r12258, r12300 and r12302 (global regexp). (Closed)

Created:
8 years, 4 months ago by Yang

Modified:
8 years, 4 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert r12258, r12300 and r12302 (global regexp). R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12350

Patch Set 2 : add empty line #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+783 lines, -557 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.h	View		5 chunks	+63 lines, -51 lines	0 comments	Download
M	src/jsregexp.cc	View		9 chunks	+72 lines, -227 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/runtime.cc	View	1	17 chunks	+641 lines, -270 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM, checked runtime.cc, rubber-stamping other files. https://chromiumcodereview.appspot.com/10825472/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10825472/diff/1/src/runtime.cc#newcode3121 src/runtime.cc:3121: HandleScope handles(isolate); Empty ...

8 years, 4 months ago (2012-08-21 09:43:40 UTC) #2

Yang

8 years, 4 months ago (2012-08-21 09:46:10 UTC) #3

https://chromiumcodereview.appspot.com/10825472/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10825472/diff/1/src/runtime.cc#newcode...
src/runtime.cc:3121: HandleScope handles(isolate);
On 2012/08/21 09:43:40, ulan wrote:
> Empty line is missing here.

Done.

Expand Messages | Collapse Messages

Issue 10825472: Revert r12258, r12300 and r12302 (global regexp). (Closed)

Description

Patch Set 1 #

Patch Set 2 : add empty line #

Messages