Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/plugin_error.h

Issue 10825462: Add browser_test to check that NaCl is logging UMA samples correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/nacl/nacl_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 * Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /* 7 /*
8 * Error codes and data structures used to report errors when loading a nexe. 8 * Error codes and data structures used to report errors when loading a nexe.
9 */ 9 */
10 10
11 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H 11 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H
12 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H 12 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H
13 13
14 #include <string> 14 #include <string>
15 15
16 #include "native_client/src/include/nacl_macros.h"
17
16 namespace plugin { 18 namespace plugin {
17 19
18 // These error codes are reported via UMA so, if you edit them: 20 // These error codes are reported via UMA so, if you edit them:
19 // 1) make sure you understand UMA, first. 21 // 1) make sure you understand UMA, first.
20 // 2) update src/tools/histograms/histograms.xml in 22 // 2) update src/tools/histograms/histograms.xml in
21 // svn://svn.chromium.org/chrome-internal/trunk/src-internal 23 // svn://svn.chromium.org/chrome-internal/trunk/src-internal
22 // Values are explicitly specified to make sure they don't shift around when 24 // Values are explicitly specified to make sure they don't shift around when
23 // edited, and also to make reading about:histograms easier. 25 // edited, and also to make reading about:histograms easier.
24 enum PluginErrorCode { 26 enum PluginErrorCode {
25 ERROR_LOAD_SUCCESS = 0, 27 ERROR_LOAD_SUCCESS = 0,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 96
95 private: 97 private:
96 PluginErrorCode error_code_; 98 PluginErrorCode error_code_;
97 std::string message_; 99 std::string message_;
98 NACL_DISALLOW_COPY_AND_ASSIGN(ErrorInfo); 100 NACL_DISALLOW_COPY_AND_ASSIGN(ErrorInfo);
99 }; 101 };
100 102
101 } // namespace plugin 103 } // namespace plugin
102 104
103 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H 105 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H
OLDNEW
« no previous file with comments | « chrome/test/nacl/nacl_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698