Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2282)

Unified Diff: build/common.gypi

Issue 10825461: only default incremental linking on for ninja in shared_library (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7fd9f21b3a6f2d9c06ebb52a66cdf6edb3a6db0b..57f692d1f3a88551caf3e81072c8a13fccf26f47 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1046,8 +1046,11 @@
['component=="shared_library"', {
'win_use_allocator_shim%': 0,
}],
- ['"<(GENERATOR)"=="ninja"', {
+ ['component=="shared_library" and "<(GENERATOR)"=="ninja"', {
# Only enabled by default for ninja because it's buggy in VS.
+ # Not enabled for component=static_library because some targets
+ # are too large and the toolchain fails due to the size of the
+ # .obj files.
'incremental_chrome_dll%': 1,
}],
# Whether to use multiple cores to compile with visual studio. This is
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698