Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10825461: only default incremental linking on for ninja in shared_library (Closed)

Created:
8 years, 4 months ago by scottmg
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Only default incremental linking on in shared_library static_library + incremental explodes due to overly large size when all the .objs are pulled into the final binary. BUG=143660 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/common.gypi View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
8 years, 4 months ago (2012-08-20 19:59:18 UTC) #1
scottmg
8 years, 4 months ago (2012-08-20 19:59:22 UTC) #2
jam
lgtm
8 years, 4 months ago (2012-08-20 20:11:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10825461/1
8 years, 4 months ago (2012-08-20 20:11:53 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:30:06 UTC) #5
Change committed as 152412

Powered by Google App Engine
This is Rietveld 408576698