Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825459: gdata: Move task related functions like RunTaskOnUIThread from gdata_file_system.cc to task_util.cc (Closed)

Created:
8 years, 4 months ago by hashimoto
Modified:
8 years, 4 months ago
Reviewers:
satorux1, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Move task related functions like RunTaskOnUIThread from gdata_file_system.cc to task_util.cc BUG=143564 TEST=unit_tests --gtest_filter="GData*" TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -112 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 3 chunks +1 line, -112 lines 0 comments Download
A chrome/browser/chromeos/gdata/task_util.h View 1 chunk +121 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/task_util.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
8 years, 4 months ago (2012-08-20 18:25:57 UTC) #1
satorux1
LGTM. Thanks!
8 years, 4 months ago (2012-08-20 18:40:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10825459/1
8 years, 4 months ago (2012-08-20 19:28:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 10825459-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-20 19:28:46 UTC) #4
hashimoto
TBR-ing ben@ for gyp changes
8 years, 4 months ago (2012-08-20 21:46:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10825459/1
8 years, 4 months ago (2012-08-20 21:47:09 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 00:02:13 UTC) #7 
Change committed as 152438

Powered by Google App Engine
This is Rietveld 408576698