Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 10825455: Merge 152136 - Remove call to UserManager::Get when initializing UserManager (Closed)

Created:
8 years, 4 months ago by bshe
Modified:
8 years, 4 months ago
Reviewers:
bshe
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 152136 - Remove call to UserManager::Get when initializing UserManager This CL removes UserManager::Get()(for ephemeral user check) out from WallpaperManager::SaveUserWallpaperProperties(called when initializing UserManager). It was creating a deadlock and make chrome hang on startup screen. The ephemeral user check in SaveUserWallpaperProperties is not correct either. We should not check if current logged in user is ephemeral user while we try to save wallpaper properties for some other user specified by email. BUG=142440 Review URL: https://chromiumcodereview.appspot.com/10829381 TBR=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -35 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.cc View 7 chunks +17 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.h View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 6 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bshe
8 years, 4 months ago (2012-08-20 16:16:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698