Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 10825445: dart2dart Fix renaming of top-level setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart
diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
index 52322394425f3b619685f9beda0fcaab0852d93e..9c4d614a767db57974c71055974545ef4d29bc0c 100644
--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart
+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
@@ -303,6 +303,9 @@ class PlaceholderCollector extends AbstractVisitor {
if (element !== null) {
if (element.isInstanceMember()) {
tryMakePrivateIdentifier(send.selector.asIdentifier());
+ } else if (element.isTopLevel()) {
+ assert(element is VariableElement || element.isSetter());
+ makeElementPlaceholder(send.selector, element);
} else {
assert(send.selector is Identifier);
tryMakeLocalPlaceholder(element, send.selector);
« no previous file with comments | « no previous file | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698