Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10825444: Add a function that calculates the size of WebSocket frame header. (Closed)

Created:
8 years, 4 months ago by Yuta Kitamura
Modified:
8 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add a function that calculates the size of WebSocket frame header. This function will be used to determine the size of buffer needed for writing WebSocket frame header. BUG=116624 R=mmenke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152518

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Matt's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M net/websockets/websocket_frame.h View 2 chunks +10 lines, -4 lines 0 comments Download
M net/websockets/websocket_frame.cc View 1 4 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yuta Kitamura
Matt, could you review this? Feel free to add willchan as a reviewer if you ...
8 years, 4 months ago (2012-08-20 09:02:43 UTC) #1
mmenke
LGTM. Seems like a good idea. http://codereview.chromium.org/10825444/diff/1/net/websockets/websocket_frame.cc File net/websockets/websocket_frame.cc (right): http://codereview.chromium.org/10825444/diff/1/net/websockets/websocket_frame.cc#newcode54 net/websockets/websocket_frame.cc:54: int header_size = ...
8 years, 4 months ago (2012-08-20 16:33:46 UTC) #2
Yuta Kitamura
Thanks! http://codereview.chromium.org/10825444/diff/1/net/websockets/websocket_frame.cc File net/websockets/websocket_frame.cc (right): http://codereview.chromium.org/10825444/diff/1/net/websockets/websocket_frame.cc#newcode54 net/websockets/websocket_frame.cc:54: int header_size = On 2012/08/20 16:33:46, Matt Menke ...
8 years, 4 months ago (2012-08-21 04:22:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/10825444/4
8 years, 4 months ago (2012-08-21 04:23:55 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 06:41:32 UTC) #5
Change committed as 152518

Powered by Google App Engine
This is Rietveld 408576698