Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 10825442: Fix the compile errors for mesa on Android (Closed)

Created:
8 years, 4 months ago by yongsheng
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the compile errors for mesa on Android There are some compile errors for mesa when trying to build gpu_tests on Android. They were fixed in the mesa upstream. So this patch combines 3 commits from mesa upstream. They are: 1) Commit eb0ff1a1c0 by chad@chad-versace.us: remove the use of fpu_control.h 2) Commit 504f92c739 by olvaffe@gmail.com: android has no log2f nor ffs 3) Commit 497baf4e4a by ian.d.romanick@intel.com: Use C-style system headers in C++ code to avoid issues with std:: namespace BUG=138226 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M third_party/mesa/MesaLib/src/glsl/glsl_parser_extras.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/glsl/ir.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mesa/MesaLib/src/mesa/main/compiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mesa/MesaLib/src/mesa/main/debug.c View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/mesa/MesaLib/src/mesa/main/imports.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/mesa/MesaLib/src/mesa/main/imports.c View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mesa/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yongsheng
I'm afraid mesa won't be upgraded soon so that I pick up these patches from ...
8 years, 4 months ago (2012-08-20 05:24:23 UTC) #1
yongsheng
+Sami, the webgl tests reporter on crbug.com
8 years, 4 months ago (2012-08-20 06:08:42 UTC) #2
Sami
lgtm
8 years, 4 months ago (2012-08-20 09:50:50 UTC) #3
yongsheng
On 2012/08/20 09:50:50, Sami wrote: > lgtm thanks, I'll try to enable gpu_tests on Android. ...
8 years, 4 months ago (2012-08-20 09:52:57 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
8 years, 4 months ago (2012-08-20 19:53:07 UTC) #5
yongsheng
On 2012/08/20 19:53:07, kbr wrote: > lgtm thanks for you two.
8 years, 4 months ago (2012-08-21 01:20:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825442/1
8 years, 4 months ago (2012-08-21 01:27:49 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 04:35:23 UTC) #8
Change committed as 152502

Powered by Google App Engine
This is Rietveld 408576698