Fix lowercasing output filenames for dart:3320 as well as fix for co19 test

Fix lowercasing output filenames for dart:3320 as well as fix for co19 test


BUG=dart:3320
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=11488

[Johnni Winther, 2012-08-22 13:59:48]

I looks good. Could you try to replace the implementation of both methods to use
the Path class in dart:io?

[aam-me, 2012-08-23 22:35:06]

Thank you, Johnni, for the suggestion.
Existing methods functionality is fully covered by Path class.
One caveat came up, though: filenames.dart implementation of toNativePath has
extra check for "nativePath.length > 3". I would add that check to toNativePath
in path_impl.dart too so the code looks like this:

=== line ~163
  String toNativePath() {
    if (Platform.operatingSystem == 'windows') {
      String nativePath = _path;
      // Drop '/' before a drive letter.
      if (nativePath.length > 3 && nativePath.startsWith('/') && nativePath[2]
== ':') {
        nativePath = nativePath.substring(1);
      }
      nativePath = nativePath.replaceAll('/', '\\');
      return nativePath;
    }
    return _path;
  }
===

What do you think? Should I add this change to this CL?

[Johnni Winther, 2012-08-24 08:25:38]

On 2012/08/23 22:35:06, aam wrote:
> Thank you, Johnni, for the suggestion.
> Existing methods functionality is fully covered by Path class.
> One caveat came up, though: filenames.dart implementation of toNativePath has
> extra check for "nativePath.length > 3". I would add that check to
toNativePath
> in path_impl.dart too so the code looks like this:
> 
> === line ~163
>   String toNativePath() {
>     if (Platform.operatingSystem == 'windows') {
>       String nativePath = _path;
>       // Drop '/' before a drive letter.
>       if (nativePath.length > 3 && nativePath.startsWith('/') && nativePath[2]
> == ':') {
>         nativePath = nativePath.substring(1);
>       }
>       nativePath = nativePath.replaceAll('/', '\\');
>       return nativePath;
>     }
>     return _path;
>   }
> ===
> 
> What do you think? Should I add this change to this CL?

Yes, do that. Put whesse@google.com as reviewer as well.

[aam-me, 2012-08-24 12:35:06]

All done. Bill, Johnni, please, review.

[Johnni Winther, 2012-08-28 08:52:56]

lgtm

[Bill Hesse, 2012-08-28 15:24:00]

LGTM.  This is wonderful!

[aam-me, 2012-08-29 04:19:16]

Johnni, I committed the CL.

 I haven't realized, though, that you are the owner of the original bug report
http://code.google.com/p/dart/issues/detail?id=3320 and might have planned
committing it yourself. Apologies if that was your intention.

[Johnni Winther, 2012-08-29 07:08:01]

On 2012/08/29 04:19:16, aam wrote:
> Johnni, I committed the CL.
> 
>  I haven't realized, though, that you are the owner of the original bug report
> http://code.google.com/p/dart/issues/detail?id=3320 and might have planned
> committing it yourself. Apologies if that was your intention.

It wasn't my intention. Thank for the CL and for committing!